Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/fcos/v1_5_exp: use array of extension instead of string #316

Merged
merged 1 commit into from
Jan 27, 2022
Merged

config/fcos/v1_5_exp: use array of extension instead of string #316

merged 1 commit into from
Jan 27, 2022

Conversation

jmarrero
Copy link
Member

Use []struct: #304 (comment)

@jmarrero jmarrero requested a review from bgilbert January 26, 2022 11:32
cgwalters
cgwalters reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me!

@bgilbert bgilbert mentioned this pull request Jan 27, 2022
Merged
bgilbert
bgilbert reviewed Jan 27, 2022
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit; LGTM otherwise.

config/fcos/v1_5_exp/schema.go Outdated Show resolved Hide resolved
@bgilbert
Copy link
Contributor

Oh, also, spec docs need updating.

@jmarrero
Copy link
Member Author

Oh, also, spec docs need updating.

Added the doc based on another list of objects I saw in the docs. Let me know if I missed anything.

bgilbert
bgilbert reviewed Jan 27, 2022
View reviewed changes
config/fcos/v1_5_exp/validate.go Outdated Show resolved Hide resolved
config/fcos/v1_5_exp/validate_test.go Outdated Show resolved Hide resolved
config/common/errors.go Outdated Show resolved Hide resolved
@jmarrero jmarrero force-pushed the extentions-struct branch 2 times, most recently from 3477a84 to a7a8363 Compare January 27, 2022 16:51
@jmarrero jmarrero merged commit 4428473 into coreos:main Jan 27, 2022
@jmarrero jmarrero mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon left review comments

@cgwalters cgwalters cgwalters left review comments

@bgilbert bgilbert bgilbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmarrero @bgilbert @cgwalters @jlebon