Handle ro /boot #118
Merged
Handle ro /boot #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinfan001
force-pushed
the
kfan-ro-handling
branch
from
9eaedb6 to
c10225e
Compare
The /boot and /boot/efi mount points may be read-only, so remount them as read-write if necessary when writing.
In the future, FCOS' /boot and /boot/efi may be read-only. Remount them as read-write before attempting to write to those locations.
kelvinfan001
force-pushed
the
kfan-ro-handling
branch
from
c10225e to
79d8563
Compare
Closed
cgwalters
reviewed
Dec 1, 2020
| @@ -115,6 +117,9 @@ bootupctl update | tee out.txt | |||
| assert_file_has_content_literal out.txt 'No update available for any component' | |||
| assert_not_file_has_content_literal out.txt 'Updated EFI' | |||
|
|
|||
| # Ensure /boot and /boot/efi can be written to | |||
| mount -o remount,rw ${bootmount} | |||
| mount -o remount,rw ${bootefimount} | |||
There was a problem hiding this comment.
This is OK for now, but in the future we can clean this up by having the test do something like re-exec itself in a new mount namespace so we're not affecting the main one.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kelvinfan001 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes from #116
Tested on FCOS with /boot and /boot/efi mounted ro.