Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart options for pod dnsConfig and dnsPolicy #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add chart options for pod dnsConfig and dnsPolicy #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/coredns/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ spec:
{{- if .Values.securityContext }}
securityContext:
{{- toYaml .Values.securityContext | nindent 10 }}
{{- end }}
{{- if .Values.dnsPolicy }}
dnsPolicy: {{ .Values.dnsPolicy }}
{{- end }}
{{- if .Values.dnsConfig }}
dnsConfig:
{{ toYaml .Values.dnsConfig | nindent 8 }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ toYaml .Values.dnsConfig | nindent 8 }}
{{- toYaml .Values.dnsConfig | nindent 8 }}

{{- end }}
volumes:
- name: config-volume
Expand Down
6 changes: 6 additions & 0 deletions charts/coredns/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,12 @@ topologySpreadConstraints: []
# Ref: https://kubernetes.io/docs/user-guide/node-selection/
nodeSelector: {}

# Configure pod DNS policy and config.
# dnsPolicy: None
# dnsConfig:
# nameservers:
# - 8.8.8.8
Comment on lines +202 to +206
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment per attribute, e,g,:

Suggested change
# Configure pod DNS policy and config.
# dnsPolicy: None
# dnsConfig:
# nameservers:
# - 8.8.8.8
# Configure pod DNS policy
# dnsPolicy: None
# Configure dnsConfig settings
# dnsConfig:
# nameservers:
# - 8.8.8.8


# expects input structure as per specification https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#toleration-v1-core
# for example:
# tolerations:
Expand Down