Ent 5267 #13
Open
Ent 5267 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blsemo
reviewed
Jul 30, 2020
| <column name="value" type="int"/> | ||
| <column name="lender" type="NVARCHAR(64)"/> | ||
| <column name="borrower" type="NVARCHAR(64)"/> | ||
| <column name="linear_id" type="uuid"/> |
There was a problem hiding this comment.
I believe this needs to beof type VARCHAR(64) when using uuid-char in the type annotation.
Comment on lines
+7
to
+8
| <include file="migration/iou.changelog-v1.xml"/> | ||
| </databaseChangeLog> |
There was a problem hiding this comment.
You have changelog v1 and v2, but only including v1 here?
There was a problem hiding this comment.
sorry i will remove v2. I had added that to test database upgrades.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before merging, please change corda version to 4.6.