Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "token-selection" module #69

Open
wants to merge 1 commit into
base: token-template
Choose a base branch
from
Open

Add "token-selection" module #69

wants to merge 1 commit into from

Conversation

waynelcw
Copy link

@waynelcw waynelcw commented Jan 20, 2020

The documentation of Token-SDK has updated with introducing DatabaseTokenSelection. But this class cannot be found in this template.
The reason is that tokens-selection module is not included in the dependency.

Suggest that either:

  • Add the module into the dependency list (this PR); OR
  • Add more documentation about "tokens-selection" module for new developers to access the class DatabaseTokenSelection

Whilst he documentation in Token-SDK has been updated with DatabaseTokenSelection, this class cannot be found in the template.
The reason is that tokens-selection is not included in the dependency.

Suggest that either:
- Add the module into the dependency list (this PR)
- More documentations about "tokens-selection" module for new developers to access the class DatabaseTokenSelection
@roger-that-dev
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants