-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-20824: Merging forward updates from release/os/5.2 to release/os/5.3 - 2024-10-09 #6359
base: release/os/5.3
Are you sure you want to change the base?
CORE-20824: Merging forward updates from release/os/5.2 to release/os/5.3 - 2024-10-09 #6359
Commits on Oct 8, 2024
-
CORE-19384: Add reset after RebalanceInProgressException (#6181)
When lost membership requests were investigated it seems to be a problem that occurs during rebalance in the state and event pattern. After the rebalance the commits that were not successful don't get re-processed and are instead skipped over. As part of handling this, this adds a reset of the event offset position so we try processing again from the correct place after a RebalanceInProgressException.
Configuration menu - View commit details
-
Copy full SHA for 609cfbf - Browse repository at this point
Copy the full SHA 609cfbfView commit details -
CORE-20799: Change CommitFailedException classification (#6295)
Change CommitFailedException classification from fatal to transient. This is required as the kafka connection tests exposed that we mark CommitFailedException as fatal and therefore do not retry. A CommitFailedException means we should abort the transaction but by classifying it as fatal we will bubble this up and we will not retry on any level. A CommitFailedException is fatal at the transaction level but not at the worker level so this should be changed.
Configuration menu - View commit details
-
Copy full SHA for 03ef673 - Browse repository at this point
Copy the full SHA 03ef673View commit details -
This issue appeared while running kafka connection tests which kill the kafka broker. When the connection to the kafka broker was lost, ERROR level logs related to CryptoOpsClientImpl appeared several times. This is because there was a failure in executing net.corda.data.crypto.wire.ops.rpc.queries.SupportedSchemesRpcQuery. It has been verified how this is handled in the rest worker: KeyRestResource calls listSchemes and fails at cryptoOpsClient.getSupportedSchemes. The exception handling for listSchemes will return an InternalServerException. This extends HttpApiException and the response code will be 500. As we return an error to the rest client and the system can recover, the log level for the CryptoOpsClient failing the operation should be WARN level instead.
Configuration menu - View commit details
-
Copy full SHA for 44fd98d - Browse repository at this point
Copy the full SHA 44fd98dView commit details -
CORE-20797 Adding handling for CordaMessageAPIProducerRequiresReset e…
…xception (#6299) This change ensures that the exception `CordaMessageAPIProducerRequiresReset` is correctly handled, by re-raising it to the context which owns the `CordaProducer` and resetting the producer safely. Unit tests have also been added to verify this behaviour.
Configuration menu - View commit details
-
Copy full SHA for 3b05a6c - Browse repository at this point
Copy the full SHA 3b05a6cView commit details -
CORE-20795: Add exception handling and retry to KafkaAdmin and Virtua…
…lNodeInfoProcessor (#6296) This issue appeared while running kafka connection tests which kill the kafka broker. In a flow worker compacted subscription we got a org.apache.kafka.common.errors.TimeoutException and handled it as fatal. This is because we have no error handling in our KafkaAdmin class for the exceptions that can be thrown by KafkaFuture.get() . The KafkaAdmin client is called from the VirtualNodeInfoProcessor which also does not catch this. This PR adds retry logic to the KafkaAdmin for getTopics and in the case of exhausting these retries, error handling in VirtualNodeInfoProcessor to handle this better and prevent this exception bubbling further.
Configuration menu - View commit details
-
Copy full SHA for 104f19e - Browse repository at this point
Copy the full SHA 104f19eView commit details -
CORE-20797 Adding CordaMessageAPIProducerRequiresReset exception to E…
…xceptionUtils (#6311) This is required so that the exception is correctly handled in the Kafka message patterns.
Configuration menu - View commit details
-
Copy full SHA for 0b98ca0 - Browse repository at this point
Copy the full SHA 0b98ca0View commit details -
CORE-20794 Catching ProducerFencedException and rethrowing as a Produ…
…cerRequiresReset (#6303) The `ProducerFencedException` in these cases is likely due to an invalid epoch being used in an operation as a result of a timeout on the broker side. The correct action in this case is to reset the producer.
Configuration menu - View commit details
-
Copy full SHA for 47994ec - Browse repository at this point
Copy the full SHA 47994ecView commit details
Commits on Oct 9, 2024
-
Merging forward updates from release/os/5.2 to release/os/5.3 - 2024-…
…10-09
r3-build committedOct 9, 2024 Configuration menu - View commit details
-
Copy full SHA for ec632f9 - Browse repository at this point
Copy the full SHA ec632f9View commit details