R3SOL-368 Move ledger flow code from components into a new library #6353
Conversation
williamvigorr3
force-pushed
the
WillV/R3SOL-368-Extract-Ledger-Lib
branch
from
ac9b06e
to
c36fb62
Compare
|
Jenkins build for PR 6353 build 12 Build Successful: |
There was a problem hiding this comment.
Why do all those impl packages now need package-info files? Exporting an impl is usually a smell...
There was a problem hiding this comment.
If I don't export these then I get the following error (so it looks like the exports are needed by the ledger flow tests):
> Task :components:ledger:ledger-utxo-flow:resolve FAILED
Resolution failed. Capabilities satisfying the following requirements could not be found:
[<<INITIAL>>]
⇒ osgi.identity: (osgi.identity=ledger-utxo-flow-tests)
⇒ [ledger-utxo-flow-tests version=5.3.0.0-SNAPSHOT]
⇒ osgi.wiring.package: (osgi.wiring.package=net.corda.ledger.lib.utxo.flow.impl.timewindow)
These were exported in their original location (except libs/ledger-lib-utxo-flow/src/main/java/net/corda/ledger/lib/utxo/flow/impl/transaction/factory/impl/package-info.java I'll try and work out why I needed to export that).
For example:
There was a problem hiding this comment.
iirc, when we exported an impl it was to get an integration test to work or something like that.
There was a problem hiding this comment.
I can't get the tests to resolve without libs/ledger-lib-utxo-flow/src/main/java/net/corda/ledger/lib/utxo/flow/impl/transaction/factory/impl/package-info.java (as well).
|
Nothing has jumped out to me as being wrong when i reviewed the diff, will take a closer look though. |
|
No description provided.