CORE-19840 Make pub_key_hash part of PK for signature table
#1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `signature_idx` column and use `pub_key_hash` in the primary key instead, which simplifies the insert and `ON CONFLICT` logic, while ensuring that we don't have issues when storing a filtered transaction followed by a signed transaction for the same transaction id.
|
|
Jenkins build for PR 1631 build 1 Build Successful: |
|
Scanning for breaking API changes introduced by this PR Scan Succeeded |
lankydan
deleted the
dan/CORE-19840-send-backchain-when-receiver-has-filtered-transaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
signature_idxcolumn and usepub_key_hashin the primary key instead, which simplifies the insert andON CONFLICTlogic, while ensuring that we don't have issues when storing a filtered transaction followed by a signed transaction for the same transaction id.