Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-20347: Add link ack in #1614

Closed
wants to merge 3 commits into from
Closed

CORE-20347: Add link ack in #1614

wants to merge 3 commits into from

Conversation

yift-r3
Copy link
Contributor

@yift-r3 yift-r3 commented Apr 18, 2024 •
edited
Loading

See details in the runtime pull request corda/corda-runtime-os#6061

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Apr 18, 2024 •
edited
Loading

Jenkins build for PR 1614 build 3

Build Successful:
Jar artifact version produced by this PR: 5.3.0.212-alpha-1713800316025

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1614/1/ has failed for PR 1614 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yift-r3 yift-r3 mentioned this pull request Apr 23, 2024
Closed
@yift-r3 yift-r3 requested a review from a team April 26, 2024 09:05
@yift-r3 yift-r3 marked this pull request as ready for review April 26, 2024 09:05
@yift-r3 yift-r3 requested a review from a team as a code owner April 26, 2024 09:05
simon-johnson-r3
simon-johnson-r3 reviewed May 1, 2024
View reviewed changes
...main/resources/net/corda/schema/configuration/p2p.linkManager/1.0/corda.p2p.linkManager.json
@@ -171,12 +171,6 @@
"type": "object",
"default": {},
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't remove config properties, see https://r3-cev.atlassian.net/wiki/spaces/CB/pages/4564091182/Making+a+Config+Change#Not-Permitted-Changes

The reason being 5.3 Corda will read 5.2 config on startup after an upgrade, it will see this property from the existing config and flag it's an invalid property not in its schema and fail.

simon-johnson-r3
simon-johnson-r3 requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@simon-johnson-r3 simon-johnson-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config property removed.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 9, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this May 16, 2024
@github-actions github-actions bot deleted the yift/core-20347/integration branch June 6, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-johnson-r3 simon-johnson-r3 simon-johnson-r3 requested changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yift-r3 @simon-johnson-r3