Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA5-15 Recurring merge from main #1320

Merged
merged 43 commits into from
Nov 7, 2023

Conversation

ac101m
Copy link
Contributor

@ac101m ac101m commented Oct 27, 2023

Changes

  • Merge release/os/5.1
  • Bump API version to 25

Notes

tomstark99 and others added 30 commits September 27, 2023 16:46
* Change ACL mappings to add tokenSelection worker.
Add index on the version field to improve optimistic locking checks.
Update recently introduced index so it uses both the "key" and
"version" columns as both are used by the State Manager during update
and delete queries.
)

CORE-17431 Create utxo_transaction_metadata for storing metadata since it is relatively large but does not change frequently. Also, two new fields for accessing signed group parameters and CPI file checksum easier.
…ed columns and renaming (#1288)

The created and is_ref_input columns are unnecessary to have in the utxo_transaction_sources table.
The created column will be the same as in utxo_transaction_component table and it’s a 1:1 mapping.
Whether a state is an input or a reference can be found out by using the groupIdx column rather than having an extra is_ref_input column.

Also rename the ref_transaction_id and ref_leaf_idx columns as those are quite confusing.
Remove mentioning of attachments from the API - this has never been implemented and is unlikely to make an appearance soon, so having dead API calls is misleading.
Add `findUnconsumedStatesByExactType` to `UtxoLedgerService `, allowing developers to retrieve states by type from the vault in pages. This dissuades developers from retrieving every state from the vault in one go and returning them to a flow.

Remove the non-paged version of the API.
@ac101m ac101m requested review from a team as code owners October 27, 2023 13:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 27, 2023

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1320/2/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 27, 2023

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1320/2/ has failed for PR 1320 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 27, 2023

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1320/2/ has failed for PR 1320 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 27, 2023

Jenkins build for PR 1320 build 3

Build Successful:
Jar artifact version produced by this PR: 5.1.0-INTEROP.25-alpha-1699373241532

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

Copy link
Collaborator

@wzur-r3 wzur-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me for Jenkinsfiles and Gradle configuration files

@ac101m ac101m merged commit 3854c4f into release/interop/syntax Nov 7, 2023
5 of 6 checks passed
@ac101m ac101m deleted the alex/DA5-15-recurring-merge-2 branch November 7, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.