CORE-17391 Add command metadata to registration state so command history can be tracked #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 1269 build 6 Build Successful: |
charlieR3
force-pushed
the
charlie/CORE-17391
branch
from
2092f11
to
7e4cc5f
Compare
dimosr
reviewed
Sep 29, 2023
data/avro-schema/src/main/resources/avro/net/corda/data/membership/state/RegistrationState.avsc
Outdated
Show resolved
Hide resolved
data/avro-schema/src/main/resources/avro/net/corda/data/membership/state/CommandMetadata.avsc
Outdated
Show resolved
Hide resolved
data/avro-schema/src/main/resources/avro/net/corda/data/membership/state/CommandMetadata.avsc
Outdated
Show resolved
Hide resolved
data/avro-schema/src/main/resources/avro/net/corda/data/membership/state/RegistrationState.avsc
Outdated
Show resolved
Hide resolved
data/avro-schema/src/main/resources/avro/net/corda/data/membership/state/CommandMetadata.avsc
Outdated
Show resolved
Hide resolved
Co-authored-by: Dimos Raptis <[email protected]>
dimosr
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a command history to the registration state so that registration handlers can take appropriate action based on the previously completed stages. The main use case for this at the moment is to handle replays at the p2p level which cause repeat processing of registration commands. Using the previously processed command list, we can determine in a command processor whether a stage has already been processed successfully or not.