Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-14355 Interop/Facade method returns unwrapped result #1168

Conversation

szymonsztuka
Copy link

@szymonsztuka szymonsztuka commented Jul 3, 2023

Removal of InteropAction<T>, ClientAction<T> and ServerResponse<T> classes as they are no longer needed.

See description of the matching PR in corda-runtime-os: corda/corda-runtime-os#4160

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 3, 2023

Jenkins build for PR 1168 build 3

Build Successful:
Jar artifact version produced by this PR: 5.1.0-INTEROP.12-alpha-1688481653513

@szymonsztuka szymonsztuka marked this pull request as ready for review July 6, 2023 10:07
@szymonsztuka szymonsztuka requested a review from a team as a code owner July 6, 2023 10:07
Copy link
Contributor

@ac101m ac101m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yarivus yarivus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(great simplification from the developer PoV)

@szymonsztuka szymonsztuka merged commit a922f47 into release/interop/syntax Jul 7, 2023
1 check passed
@szymonsztuka szymonsztuka deleted the interop/szymon.core-14355-facade-method-returns-unwrapped-result branch July 7, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants