ES-617: Add Gradle version catalog implementation for corda-api #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 15, 2023 15:02
|
Jenkins build for PR 1151 build 22 Build Successful: |
knguyen-r3
changed the title
|
This PR is stale because it has been open 7 days with no activity. Remove the |
|
This PR was closed because it has been stale for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As part improving version dependencies within Corda we have added Gradle Version Catalog for corda-api. This will allow us to use the newly created central repository corda-version-catalog for maintaining and managing 3rd parties dependency that is use within corda-api.
Changes:
Added implementation of using Gradle Version Catalog for corda-api repo in build.gradle file
Replace all version reference occurrences which use gradle.properties to version catalog in build.gradle files.
snakeyamlVersion=2.0
avroVersion = 1.11.1
bouncycastleVersion = 1.73
jacksonVersion = 2.15.0
assertjVersion = 3.24.+
mockitoVersion = 5.3.+
mockitoKotlinVersion = 4.1.+
Testing
Tested with Artifactory cordaVersionCatalog=5.0.0-alpha-1687973674215 created from this PR in version catalog repo.
Documentation
Rendered version: https://github.com/corda/platform-eng-design/blob/knguyen/ES-374/gradle_version_catalog/core/corda-5/corda-5.0/infrastructure/build/build-dependencies/corda5-version-catalog.md