Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-15313: release prep for GA-RC10 #94

Conversation

christian-napoles-r3
Copy link
Contributor

@christian-napoles-r3 christian-napoles-r3 commented Jul 11, 2023

https://r3-cev.atlassian.net/browse/CORE-15313

following the steps to prepare a RC branch

@christian-napoles-r3
Copy link
Contributor Author

christian-napoles-r3 commented Jul 12, 2023

I'm convinced this needs to change still:

// R3 Internal repositories for dev
// Repository provides Corda 5 binaries that implement Corda-API.
// These will be made publicly available.
// Final location to be decided.
// Repository subject to change
maven {
url = "$artifactoryContextUrl/corda-os-maven"
authentication {
basic(BasicAuthentication)
}
credentials {
username = findProperty('cordaArtifactoryUsername') ?: System.getenv('CORDA_ARTIFACTORY_USERNAME')
password = findProperty('cordaArtifactoryPassword') ?: System.getenv('CORDA_ARTIFACTORY_PASSWORD')
}
}
}

this looks like an internal dependence

Copy link
Contributor

@marvincudjoe marvincudjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous release PR looks very useful. #84
There are some internal references in gradle.properties and settings.gradle that can be removed as well

@christian-napoles-r3
Copy link
Contributor Author

stale branch. prepping for RC-12 or GA build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants