Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware): v4 experimental middleware #986

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jptosso
Copy link
Member

@jptosso jptosso commented Feb 7, 2024

THIS PR DEPENDS ON #1201

@jptosso jptosso requested a review from a team as a code owner February 7, 2024 00:18
@jptosso jptosso marked this pull request as draft February 7, 2024 00:19
jptosso and others added 3 commits February 7, 2024 01:41
…ooks to the middleware.

This is specially useful when you want to use transaction data to populate things like logs or spans in a trace enriching the experience and connecting the dots with observability.
experimental/middleware/middleware.go Outdated Show resolved Hide resolved
experimental/middleware/middleware.go Outdated Show resolved Hide resolved
experimental/middleware/middleware.go Outdated Show resolved Hide resolved
experimental/middleware/middleware.go Outdated Show resolved Hide resolved
@fzipi
Copy link
Member

fzipi commented Apr 27, 2024

@jptosso Care to take a look at comments?

@fzipi
Copy link
Member

fzipi commented May 1, 2024

And provide a description about what this PR does?

@jptosso jptosso added the v4 Work for v4 label Nov 6, 2024
Copy link
Member

@jcchavezs jcchavezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to be that guy but people request this and then never show code on how they use this. Until that happens I am reluctant to add this changes.

@jptosso jptosso dismissed jcchavezs’s stale review November 13, 2024 09:03

This is required for gin and fasthttp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Work for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants