Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow selectors on *_NAMES collections #1143

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

remove debug spew call

280af44
Select commit
Loading
Failed to load commit list.
Open

feat: allow selectors on *_NAMES collections #1143

remove debug spew call
280af44
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 4, 2024 in 0s

81.48% (-1.24%) compared to 4ff1f76

View this Pull Request on Codecov

81.48% (-1.24%) compared to 4ff1f76

Details

Codecov Report

Attention: Patch coverage is 21.64502% with 181 lines in your changes missing coverage. Please review.

Project coverage is 81.48%. Comparing base (4ff1f76) to head (280af44).
Report is 75 commits behind head on main.

Files with missing lines Patch % Lines
internal/variables/variablesmap.gen.go 13.26% 170 Missing ⚠️
internal/corazawaf/transaction.go 10.00% 9 Missing ⚠️
internal/collections/named.go 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   82.72%   81.48%   -1.24%     
==========================================
  Files         162      164       +2     
  Lines        9080     7906    -1174     
==========================================
- Hits         7511     6442    -1069     
+ Misses       1319     1210     -109     
- Partials      250      254       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.