move options to env

corazawaf · Nov 13, 2024 · 5a51e8c · 5a51e8c
1 parent 2d7129e
commit 5a51e8c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/regression.yml b/.github/workflows/regression.yml
@@ -46,7 +46,8 @@ jobs:
           cache: true  
       - name: Tests and coverage
         run: |
-          go run mage.go coverage ${{ matrix.build-flag }}
+          export BUILD_TAGS="${{ matrix.build-flag }}"
+          go run mage.go coverage
       - name: "Codecov: General"
         uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4
         if: ${{ matrix.go-version == '1.22.x' }}

diff --git a/magefile.go b/magefile.go
@@ -144,8 +144,10 @@ func buildTagsFlags(tags string) string {
 }
 
 // Coverage runs tests with coverage and race detector enabled.
-func Coverage(tags string) error {
-	tags = buildTagsFlags(tags)
+// Usage: mage coverage [buildTags]
+func Coverage() error {
+	buildTags := os.Getenv("BUILD_TAGS")
+	tags := buildTagsFlags(buildTags)
 	if err := os.MkdirAll("build", 0755); err != nil {
 		return err
 	}