fix: support flatten replies

coralproject · Nov 11, 2021 · 4f5f317 · 4f5f317
1 parent 541a7ad
commit 4f5f317
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 9 deletions.
diff --git a/src/core/client/stream/tabs/Comments/Comment/ReplyCommentForm/CreateCommentReplyMutation.ts b/src/core/client/stream/tabs/Comments/Comment/ReplyCommentForm/CreateCommentReplyMutation.ts
@@ -161,7 +161,7 @@ function addCommentReplyToStory(
   const singleCommentID = lookup(environment, LOCAL_ID).commentID;
   const comment = commentEdge.getLinkedRecord("node")!;
   const depth = singleCommentID
-    ? determineDepthTillAncestor(comment, singleCommentID)
+    ? determineDepthTillAncestor(store, comment, singleCommentID)
     : determineDepthTillStory(
         store,
         comment,

diff --git a/src/core/client/stream/tabs/Comments/Stream/Subscriptions/CommentEnteredSubscription.ts b/src/core/client/stream/tabs/Comments/Stream/Subscriptions/CommentEnteredSubscription.ts
@@ -97,7 +97,7 @@ function insertReply(
   }
 
   const depth = ancestorID
-    ? determineDepthTillAncestor(comment, ancestorID)
+    ? determineDepthTillAncestor(store, comment, ancestorID)
     : determineDepthTillStory(
         store,
         comment,

diff --git a/src/core/client/stream/tabs/Comments/helpers/determineDepthTill.ts b/src/core/client/stream/tabs/Comments/helpers/determineDepthTill.ts
@@ -1,4 +1,6 @@
+import { LOCAL_ID } from "coral-framework/lib/relay";
 import { GQLCOMMENT_SORT } from "coral-framework/schema";
+import { MAX_REPLY_INDENT_DEPTH } from "coral-stream/constants";
 import {
   ConnectionHandler,
   RecordProxy,
@@ -36,10 +38,32 @@ function isCommentInsideParentRepliesConnection(comment: RecordProxy) {
     "ReplyList_replies",
     { orderBy: GQLCOMMENT_SORT.CREATED_AT_ASC }
   )!;
-
+  if (!repliesConnection) {
+    return false;
+  }
   return isNodeIDInRepliesConnection(comment.getDataID(), repliesConnection);
 }
 
+function findFlattenedParent(comment: RecordProxy, ancestorID?: string | null) {
+  const maxDepth = MAX_REPLY_INDENT_DEPTH + 1; // +1 to include root level.
+  const ancestors: RecordProxy[] = [];
+  let cur = comment;
+  while (cur) {
+    ancestors.unshift(cur);
+    if (cur.getDataID() === ancestorID) {
+      break;
+    }
+    cur = cur.getLinkedRecord("parent");
+  }
+  if (ancestors.length > maxDepth) {
+    return {
+      flattendParent: ancestors[maxDepth - 1],
+      exceededDepth: ancestors.length - maxDepth,
+    };
+  }
+  return null;
+}
+
 /**
  * Returns depth until story or null if could not trace back to
  * comments that is loaded inside the stream!
@@ -75,8 +99,12 @@ export function determineDepthTillStory(
     return null;
   }
 
-  let depth = 1;
-  let cur = firstParent;
+  // If flattenReplies start iterating from flattened Parent.
+  const flattenReplies = store.get(LOCAL_ID)?.getValue("flattenReplies");
+  const result = flattenReplies ? findFlattenedParent(comment) : null;
+  let depth = result !== null ? result.exceededDepth : 1;
+  let cur = result !== null ? result.flattendParent : firstParent;
+
   while (cur) {
     const parent: RecordProxy | null = cur.getLinkedRecord("parent");
     if (parent === null) {
@@ -103,25 +131,34 @@ export function determineDepthTillStory(
  * comments that is loaded inside the stream!
  */
 export function determineDepthTillAncestor(
+  store: RecordSourceSelectorProxy<unknown>,
   comment: RecordProxy,
   ancestorID?: string | null
 ) {
   // Already ancestor, return 0;
   if (comment.getDataID() === ancestorID) {
     return 0;
   }
-  let cur: RecordProxy | null | undefined = comment.getLinkedRecord("parent");
-  if (!cur) {
+  const firstParent: RecordProxy | null | undefined = comment.getLinkedRecord(
+    "parent"
+  );
+  if (!firstParent) {
     // It's a top level comment, so can't determine depth till ancestor.
     return null;
   }
 
   // Parent is ancestor, return 1.
-  if (cur.getDataID() === ancestorID) {
+  if (firstParent.getDataID() === ancestorID) {
     return 1;
   }
 
-  let depth = 1;
+  // If flattenReplies start iterating from flattened Parent.
+  const flattenReplies = store.get(LOCAL_ID)?.getValue("flattenReplies");
+  const result = flattenReplies
+    ? findFlattenedParent(comment, ancestorID)
+    : null;
+  let depth = result !== null ? result.exceededDepth : 1;
+  let cur = result !== null ? result.flattendParent : firstParent;
   while (cur) {
     const parent: RecordProxy | null = cur.getLinkedRecord("parent");
     if (parent !== null) {