Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-integration] feat: file log preset - allow setting max_batch_size #469

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[opentelemetry-integration] feat: file log preset - allow setting max_batch_size #469

merged 1 commit into from
Nov 4, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Nov 4, 2024

Description

Fixes ES-379

How Has This Been Tested?

kind cluster

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review November 4, 2024 12:02
daidokoro
daidokoro approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povilasv povilasv merged commit 7770e5b into master Nov 4, 2024
7 checks passed
@povilasv povilasv deleted the ES-379 branch November 4, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daidokoro daidokoro daidokoro approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @daidokoro