feat: upgrading chart dependencies #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolastakashi
requested review from
avivgold098,
ShauliSolomovich,
povilasv,
oded-dd and
matej-g
as code owners
povilasv
approved these changes
May 28, 2024
matej-g
reviewed
May 28, 2024
There was a problem hiding this comment.
Looks good, but could we add an entry into the values.yaml, even if commented out? It would good to somehow (self)document if we're adding this feature, so that users know, as right now you would need to dive into Helm chart code to notice it.
As well as mention it in the changelog.
nicolastakashi
force-pushed
the
feat/upgrading-otel-chart
branch
from
53a4dfa
to
4d3db41
Compare
Signed-off-by: Nicolas Takashi <[email protected]>
nicolastakashi
force-pushed
the
feat/upgrading-otel-chart
branch
from
4d3db41
to
b58aa13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading Helm Chart Dependencies.
How Has This Been Tested?
Checklist: