Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threshold update should increase sequence number #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Threshold update should increase sequence number #68

wants to merge 1 commit into from

Conversation

CanardMandarin
Copy link

The threshold update should invalidate previously created transactions.
Note: This change will increment the seq two times when calling set_owners_and_change_threshold.

@callensm
Copy link
Member

the owner_set_seq value is to track the current numerical sequence number of the set of owner public keys. since updating the threshold doesn't have any change implications to the owner public keys, this value should not be incremented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CanardMandarin @callensm