Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check on transaction creation #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CanardMandarin
Copy link

Hello,

I'm making a series of pull request. Feel free to refuse the ones that aren't meaningful to you.

This pull request updates the instructions create_transaction and execute_transaction.

The instruction create_transaction now ensures that the multisig_signer account is present as a signer in the account list.
I removed the multisig_signer account in the execute_transaction instruction, as it is already included in the "remaining accounts".

Pros:

  • Transaction where the multisig_signer account is not present or not a signer are refused.
  • ExecuteTransaction instruction size is now smaller and consumes less compute units.

Con:

  • Require frontend apps to update their code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant