Improved Macos CI #328
Improved Macos CI #328
Conversation
rtetley
force-pushed
the
self-hosted-macos
branch
2 times, most recently
from
ea6ee38
to
4f0a01f
Compare
|
This PR improves the platform CI introducing three things:
|
| with: | ||
| attempt_limit: 5 | ||
| attempt_delay: 5000 | ||
| shell: bash |
There was a problem hiding this comment.
@rtetley : since my shell based fix didn't work (hdiutil somehow crashes so badly that it kills the containing shell) I tried your fix. One issue: the shell: bash line seems to be not supported, but I used Wandalen/wretry.action@v1 rather than @master.
There was a problem hiding this comment.
On this PR it seemed to work fine ? Does it only fail when it requires a retry ?
There was a problem hiding this comment.
It doesn't fail, it just gives a warning.
There was a problem hiding this comment.
Sorry, likely my bad. I thought that using abbreviated version numbers (like @v1) is a github feature, but apparently it is a feature of many github actions implemented by duplicating tags - the wretry doesn't have this. So I got some random version. I will try again wit a proper version tag.
There was a problem hiding this comment.
I tried it again with:
- name: 'Build DMG installer'
uses: Wandalen/[email protected]
with:
attempt_limit: 5
attempt_delay: 5000
shell: bash
command: |
eval $(opam env)
macos/create_installer_macos.sh
This still gives a warning:
Unexpected input(s) 'shell', valid inputs are ['action', 'command', 'with', 'current_path', 'attempt_limit', 'attempt_delay']
As far as I can tell the tag v1.3.0 is identical to master (I don't like to have master versions of actions in CI).
Do you have a reference which suggests that the shell key is allowed? It would be useful to make this explicit, but it also works without it.
There was a problem hiding this comment.
Ah no, unfortunately no :-/ I hadn't noticed the warning before... I also have it on this PR...
rtetley
force-pushed
the
self-hosted-macos
branch
from
c4bd553
to
07084e4
Compare
No description provided.