-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS CI: install pkgconf instead of pkg-config #19836
Conversation
b53a581
to
89211b7
Compare
89211b7
to
c205366
Compare
Hopefully fix CI (pkgconf is a replacement of pkg-config)
c205366
to
1ee9146
Compare
|
||
- name: Install OCaml dependencies | ||
run: | | ||
export PKG_CONFIG_PATH=/usr/local/opt/libffi/lib/pkgconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this was doing anything
brew unlink pkg-config | ||
brew install gnu-time opam gtksourceview3 adwaita-icon-theme expat libxml2 pkgconf | ||
brew unlink pkgconf | ||
brew link pkg-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be working even though it's a strange back-and-forth
note that the image comes with pkg-config preinstalled AFAICT
History:
With the previous install pkg-config
we get error https://github.com/coq/coq/actions/runs/11856721924/job/33043567199?pr=19835
The following system packages will first need to be installed:
pkgconf
if we want to install pkgconf we must unlink pkg-config
then with unlink pkg-config; install pkgconf
we get https://github.com/coq/coq/actions/runs/11857007213/job/33044451483
ERROR while compiling conf-pkg-config.3
# [ERROR] Command not found: pkg-config
If we install pkgconf but unlink it in favor of pkg-config as in the current code it seems to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One solution would be to opam pin conf-pkg-config.2
when on a macos runner, then you don’t need any other change.
At some point the image will be updated with an updated homebrew cache I guess, then the pin will fail and you can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the breakage, by the way. Even if it would have happened also by releasing a version 4 of the conf package, it may have been clearer that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge as it seems to work, this can be potentially refine dlater if needed.
@coqbot merge now |
Hopefully fix CI
(pkgconf is a replacement of pkg-config)
cf ocaml/opam-repository#26891