Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagate hash fragment (=href anchor) when redirecting URLs #236

Merged
merged 2 commits into from
Dec 22, 2023
Merged

propagate hash fragment (=href anchor) when redirecting URLs #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4602f5f
let `make run` serve 404.html
brandenburg Dec 21, 2023
a6a0337
propagate hash fragment (=href anchor) when redirecting URLs
brandenburg Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pages/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<#include "incl/macros.html">
<script>
const path = window.location.pathname;
const hash = window.location.hash;
const stdlibRegex = /^\/(stdlib|library)\//;
const refmanRegex = /^\/distrib\/(.*)\/refman\//;
const V80refmanRegex = /^\/distrib\/V8.0\/doc\//;
Expand All @@ -10,25 +11,25 @@
const bugSearchRegex = /^\?id=(.*)/;
const wikiRegex = /^\/cocorico\/(.*)/;
if (stdlibRegex.test(path)) {
window.location = path.replace(stdlibRegex, "/doc/<#CURRENTVERSIONTAG>/stdlib/");
window.location = path.replace(stdlibRegex, "/doc/<#CURRENTVERSIONTAG>/stdlib/") + hash;
} else if (refmanRegex.test(path)) {
const version = path.match(refmanRegex)[1];
if (version == "current") {
window.location = path.replace(refmanRegex, "/doc/<#CURRENTVERSIONTAG>/refman/");
window.location = path.replace(refmanRegex, "/doc/<#CURRENTVERSIONTAG>/refman/") + hash;
}
else {
window.location = path.replace(refmanRegex, "/doc/" + version + "/refman/");
window.location = path.replace(refmanRegex, "/doc/" + version + "/refman/") + hash;
}
} else if (stdlibDistribRegex.test(path)) {
const version = path.match(stdlibDistribRegex)[1];
if (version == "current") {
window.location = path.replace(stdlibDistribRegex, "/doc/<#CURRENTVERSIONTAG>/stdlib/");
window.location = path.replace(stdlibDistribRegex, "/doc/<#CURRENTVERSIONTAG>/stdlib/") + hash;
}
else {
window.location = path.replace(stdlibDistribRegex, "/doc/" + version + "/stdlib/");
window.location = path.replace(stdlibDistribRegex, "/doc/" + version + "/stdlib/") + hash;
}
} else if (V80refmanRegex.test(path)) {
window.location = path.replace(V80refmanRegex, "/doc/V8.0/doc/");
window.location = path.replace(V80refmanRegex, "/doc/V8.0/doc/") + hash;
} else if (bugSimplifiedRegex.test(path)) {
const bugId = path.match(bugSimplifiedRegex)[1];
// To avoid having to rely on the correspondence table from the migration, we redirect to the search page
Expand Down
20 changes: 17 additions & 3 deletions srv/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,24 @@
import http.server
from http.server import HTTPServer, BaseHTTPRequestHandler
from http.server import SimpleHTTPRequestHandler
import socketserver

PORT = 8000

Handler = http.server.SimpleHTTPRequestHandler

class Handler(SimpleHTTPRequestHandler):
def send_error(self, code, message=None):
if code == 404:
with open("404.html", "rb") as err_msg:
page404 = err_msg.read()

self.send_response(code)
self.send_header("Connection", "close")
self.send_header("Content-Type", "text/html")
self.send_header("Content-Length", str(len(page404)))
self.end_headers()
self.wfile.write(page404)
else:
SimpleHTTPRequestHandler.send_error(self, code, message)


Handler.extensions_map={
'.manifest': 'text/cache-manifest',
Expand Down