Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate GitHub workflows on Ubuntu and macOS. #57

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Generate GitHub workflows on Ubuntu and macOS. #57

wants to merge 3 commits into from

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Aug 11, 2021

Reopening #56 from a local branch to enable pushing to Cachix.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 11, 2021

@siraben: In principle, everything has been uploaded to the coq-community Cachix already, so you should be able to start taking advantage of it (without waiting for this PR to be merged).

CohenCyril
CohenCyril reviewed Aug 16, 2021
View reviewed changes
.nix/shellHook.sh Outdated Show resolved Hide resolved
@siraben
Copy link
Member

siraben commented Dec 28, 2021 •
edited
Loading

@Zimmi48 I have the coq-community cachix in my Nix config, but I can't seem to avoid rebuilding coqPackages.VST.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 28, 2021

That's not surprising, since we haven't updated this PR in five months. I will take Cyril's comment into account and rebase this.

@Zimmi48 Zimmi48 force-pushed the enable-macos branch 2 times, most recently from 30b19f8 to d0ffddd Compare December 28, 2021 11:31
@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 28, 2021

I have implemented the suggested change. I have kept the behavior of genNixAction unchanged (doesn't produce cross-platform workflows and doesn't change their title) and introduced a new function genCrossPlatformNixAction that generates workflows for Ubuntu and macOS with information on the platform in the workflow name.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 28, 2021

Instead, we could also decide to set this in .nix/config.nix (it would probably make a lot of sense if it was set there) but I haven't really looked yet for the implementation logic that would make that possible.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 28, 2021 •
edited
Loading

Something else that we could decide is to restrict on which events we run the macOS workflows (e.g., to avoid delaying PR CI).

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 28, 2021

@CohenCyril There were three failures, all in the Cachix install step, all on the macOS platform:

Should we report them to Domen?

@siraben
Copy link
Member

siraben commented Dec 28, 2021

I encountered a similar failure recently, what if you bump the cachix action to v16?

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 28, 2021

We're already using v16 for the install-nix-action, and v10 for the cachix-action, which are the latest versions AFAICT.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 28, 2021

BTW, @siraben the VST jobs on macOS for Coq 8.12 and 8.13 (the only ones that exist AFAICS) have completed, so they should be available in Coq-community's Cachix.

@siraben
Copy link
Member

siraben commented Dec 29, 2021

@Zimmi48 Thanks, it seems to have fetched from cache now. 😊

@Zimmi48 Zimmi48 marked this pull request as ready for review December 30, 2021 11:28
@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 30, 2021

There were three failures, all in the Cachix install step, all on the macOS platform

It happened again:

cc @domenkozar

(We do not get such failures anymore in Ubuntu since the last install-nix-action update, but they still often happen on macOS apparently...)

@domenkozar
Copy link

NixOS/nix#3605

@Zimmi48
Test Coq 8.16.0 update.
efba269 
NixOS/nixpkgs#189997
@Zimmi48
Introduce genCrossPlatformNixActions command.
3e99259 
This command generates GitHub workflows on Ubuntu and macOS.
@Zimmi48
Generate Ubuntu and macOS workflows.
159f2b1 
Commit created by running the following commands:
nix-shell --arg do-nothing true --run "genCrossPlatformNixActions"
git rm ".github/workflows/nix-action-[^-]*.yml"
@Zimmi48 Zimmi48 marked this pull request as draft September 7, 2022 11:47
@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 7, 2022

Using this PR to test NixOS/nixpkgs#189997 on macOS.

@Zimmi48 Zimmi48 mentioned this pull request Sep 7, 2022
Merged
@proux01 proux01 force-pushed the master branch 3 times, most recently from 2c6348e to f32b027 Compare March 7, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenCyril CohenCyril CohenCyril left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zimmi48 @siraben @domenkozar @CohenCyril