-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GitHub caching of Nix builds. #154
base: master
Are you sure you want to change the base?
Conversation
This can apparently be a new source of spurious failures: https://github.com/coq-community/coq-nix-toolbox/actions/runs/5543815473/jobs/10120402552?pr=154 This happened for about 1% of all the builds. EDIT: this actually looks fixed in v2 of the action. |
The only place where the binary cache would have been really useful did not work:
And in the dependent job:
It's not clear that this caching mechanism will be resilient to the large number of jobs that we spawn in the Coq Nix Toolbox repository, but it might still be useful on other projects. |
As a first step, it could be worth adding GitHub caching only for the workflows who do not have write-access to a Cachix. |
@Zimmi48 I hadn't seen this. Do you think we should update and merge? |
We should probably evaluate how it behaves again. According to my last comment, it was not clear whether this was a good idea in the general case, which is how it is implemented now. So this should probably have been a draft. |
Tests the new GitHub Action provided by Determinate Systems. Cf. https://determinate.systems/posts/magic-nix-cache. This is tested from a fork, on purpose. The
pull_request
workflow for a PR opened from a fork cannot push to Cachix.