Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove P* #80

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Remove P* #80

merged 3 commits into from
Jan 9, 2020

Conversation

liyishuai
Copy link
Member

@liyishuai liyishuai commented Dec 26, 2019 •
edited
Loading

@liyishuai liyishuai requested a review from gmalecha December 26, 2019 22:40
@liyishuai liyishuai force-pushed the master branch 2 times, most recently from 3ef6419 to 93dbb2a Compare January 8, 2020 00:10
@liyishuai liyishuai changed the title Update notations Remove P* Jan 8, 2020
@liyishuai
Copy link
Member Author

@gmalecha do these look reasonable?

@liyishuai liyishuai force-pushed the master branch 4 times, most recently from 50d3402 to e3e3669 Compare January 8, 2020 18:31
gmalecha
gmalecha reviewed Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@gmalecha gmalecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. A few minor thoughts. Given that this is a breaking change, do you think that we should release it a new major version number?

_CoqProject Outdated Show resolved Hide resolved
_CoqProject Outdated Show resolved Hide resolved
theories/Data/Monads/WriterMonad.v Outdated Show resolved Hide resolved
@liyishuai
Copy link
Member Author

We should bump to v0.11.0, if not ready for v1.0.0.
These changes are breaking, but didn't break packages listed on OPAM that depend on our master branch.

@gmalecha gmalecha merged commit f258f27 into coq-community:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmalecha gmalecha gmalecha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operator priority MonadLaws are commented out
2 participants
@liyishuai @gmalecha