Merge PR OCA#1046 into 16.0

Signed-off-by alexis-via
coopiteasy · Oct 21, 2024 · c91cfc9 · c91cfc9
2 parents d4f8e4d + 41f9cb1
commit c91cfc9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/account_invoice_facturx/README.rst b/account_invoice_facturx/README.rst
@@ -42,11 +42,13 @@ With this module, the PDF customer invoices and refunds generated by the Qweb re
 Installation
 ============
 
+**WARNING**: there is an alternative implementation of Factur-X in the module **account_edi_ubl_cii** of the official addons. If both modules are installed, the XML embedded in the PDF is the XML generated by the module **account_edi_ubl_cii**. To avoid that, you need to uninstall the module **account_edi_ubl_cii**.
+
 This module requires a recent version of the Python library `factur-x <https://github.com/akretion/factur-x>`__ developped by Akretion. Note that the factur-x library depends on PyPDF2 for the low-level PDF manipulation. To install it, run:
 
 .. code::
 
-  sudo pip3 install --upgrade factur-x
+  pip3 install --upgrade factur-x
 
 Configuration
 =============

diff --git a/account_invoice_facturx/models/account_move.py b/account_invoice_facturx/models/account_move.py
@@ -396,6 +396,7 @@ def _cii_check_tax_required_info(self, tax_dict):
                     "unece_type_code": "VAT",
                     "unece_categ_code": "E",
                     "amount": 0,
+                    "amount_type": "percent",
                     "display_name": "Empty virtual tax",
                 }
             )

diff --git a/account_invoice_facturx/readme/INSTALL.rst b/account_invoice_facturx/readme/INSTALL.rst
@@ -1,5 +1,7 @@
+**WARNING**: there is an alternative implementation of Factur-X in the module **account_edi_ubl_cii** of the official addons. If both modules are installed, the XML embedded in the PDF is the XML generated by the module **account_edi_ubl_cii**. To avoid that, you need to uninstall the module **account_edi_ubl_cii**.
+
 This module requires a recent version of the Python library `factur-x <https://github.com/akretion/factur-x>`__ developped by Akretion. Note that the factur-x library depends on PyPDF2 for the low-level PDF manipulation. To install it, run:
 
 .. code::
 
-  sudo pip3 install --upgrade factur-x
+  pip3 install --upgrade factur-x
diff --git a/account_invoice_facturx/static/description/index.html b/account_invoice_facturx/static/description/index.html
@@ -391,9 +391,10 @@ <h1 class="title">Account Invoice Factur-X</h1>
 </div>
 <div class="section" id="installation">
 <h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
+<p><strong>WARNING</strong>: there is an alternative implementation of Factur-X in the module <strong>account_edi_ubl_cii</strong> of the official addons. If both modules are installed, the XML embedded in the PDF is the XML generated by the module <strong>account_edi_ubl_cii</strong>. To avoid that, you need to uninstall the module <strong>account_edi_ubl_cii</strong>.</p>
 <p>This module requires a recent version of the Python library <a class="reference external" href="https://github.com/akretion/factur-x">factur-x</a> developped by Akretion. Note that the factur-x library depends on PyPDF2 for the low-level PDF manipulation. To install it, run:</p>
 <pre class="code literal-block">
-sudo pip3 install --upgrade factur-x
+pip3 install --upgrade factur-x
 </pre>
 </div>
 <div class="section" id="configuration">