-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][ADD] hr_timesheet_sheet_prefill_multi #43
Conversation
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few cosmetics remarks, otherwise lgtm! well done, @carmenbianca! 👍
A very small patchset to clean up the code. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
8d2d982
to
07548fc
Compare
@huguesdk done |
use a related field on hr_timesheet.sheet.prefill, which solves the problem elegantly and also ensures that inactive projects are hidden in the prefill projects of employees.
i added a commit to simplify the filtering out of inactive projects. you may want to squash it with the previous one. |
@huguesdk LGTM. I think it's OK to keep as separate commit. |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at aad565f. Thanks a lot for contributing to coopiteasy. ❤️ |
Description
Be able to both sort and repeat default projects for timesheet sheets.
I'm pretty content with how this module turned out! It is as hacky as it is elegant.
To save myself from having to track two PRs, we can just merge this with
merge patch
. It will also bumphr_timesheet_sheet_prefill_multi
, but that doesn't really matter. Version numbers are arbitrary, anyway.Odoo task (if applicable)
T12533
Checklist before approval