Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][ADD] hr_timesheet_sheet_prefill_multi #43

Merged
merged 9 commits into from
Oct 11, 2024

Conversation

carmenbianca
Copy link
Member

Description

Be able to both sort and repeat default projects for timesheet sheets.

I'm pretty content with how this module turned out! It is as hacky as it is elegant.

To save myself from having to track two PRs, we can just merge this with merge patch. It will also bump hr_timesheet_sheet_prefill_multi, but that doesn't really matter. Version numbers are arbitrary, anyway.

Odoo task (if applicable)

T12533

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • (If a new module) Moving this to OCA has been considered.

Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few cosmetics remarks, otherwise lgtm! well done, @carmenbianca! 👍

hr_timesheet_sheet_prefill_multi/__manifest__.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_prefill_multi/__manifest__.py Outdated Show resolved Hide resolved
A very small patchset to clean up the code.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Copy link
Member Author

@huguesdk done

use a related field on hr_timesheet.sheet.prefill, which solves the
problem elegantly and also ensures that inactive projects are hidden in
the prefill projects of employees.
@huguesdk
Copy link
Member

i added a commit to simplify the filtering out of inactive projects. you may want to squash it with the previous one.

@carmenbianca
Copy link
Member Author

@huguesdk LGTM. I think it's OK to keep as separate commit.

@huguesdk
Copy link
Member

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-43-by-huguesdk-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit d83dc4e into 12.0 Oct 11, 2024
3 checks passed
@github-grap-bot github-grap-bot deleted the 12.0-prefill-multi branch October 11, 2024 09:42
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at aad565f. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants