[16.0] [ADD] foodhub_picking_operations #122

victor-champonnois · 2024-12-12T10:46:58Z

https://gestion.coopiteasy.be/web#id=12186&action=475&active_id=478&model=project.task&view_type=form&menu_id=536

huguesdk · 2024-12-13T10:12:02Z

foodhub_picking_operations/models/stock_move.py

+    _order = "product_category,product_default_code"
+
+    product_category = fields.Many2one(related="product_id.categ_id", store=True)


this will sort by the id of the category, not by its name. is it on purpose? otherwise, it should be like this:

Suggested change

_order = "product_category,product_default_code"

product_category = fields.Many2one(related="product_id.categ_id", store=True)

_order = "product_category_name,product_default_code"

product_category_name = fields.Many2one(related="product_id.categ_id.name", store=True)

In theory I agree with you, but in practice it works ! checkout out this delivery, on the picking operations, valdibela is sorted last, while it's id is 3 (lower than the id from tierra y liberdad). Unless the sorting is descending ?

Note that I will only keep the sorting for move lines, not moves

my bad: i just checked, and indeed, odoo does it better than i think: if a many2one field is used in _order, it will correctly use the ordering of that model, automatically joining with all needed tables.

huguesdk · 2024-12-13T10:15:01Z

foodhub_picking_operations/reports/report_picking_operations.xml

in the stock module, the file is called report_stockpicking_operations.xml. i think it can be simply named report_picking.xml, as this is also the name of the report.

huguesdk · 2024-12-13T10:15:36Z

foodhub_picking_operations/README.rst

why _operations in the module name? suggestion: foodhub_custom_stock_picking.

done, dropped the custom because it's useless I think

then i think foodhub_stock_picking is better, because picking alone is a little strange.

foodhub_picking_operations/reports/report_picking_operations.xml

Co-authored-by: hugues de keyzer <[email protected]>

huguesdk · 2024-12-17T09:07:05Z

foodhub_picking_operations/README.rst

then i think foodhub_stock_picking is better, because picking alone is a little strange.

huguesdk · 2024-12-17T09:09:19Z

foodhub_picking_operations/models/stock_move.py

+    _order = "product_category,product_default_code"
+
+    product_category = fields.Many2one(related="product_id.categ_id", store=True)


my bad: i just checked, and indeed, odoo does it better than i think: if a many2one field is used in _order, it will correctly use the ordering of that model, automatically joining with all needed tables.

huguesdk · 2024-12-17T09:10:47Z

foodhub_picking/models/stock_move_line.py

+from odoo import fields, models
+
+
+class StockMove(models.Model):


Suggested change

class StockMove(models.Model):

class StockMoveLine(models.Model):

huguesdk · 2024-12-17T09:13:14Z

foodhub_picking/models/stock_move_line.py

+# Copyright 2020 Coop IT Easy SCRL fs
+#   Robin Keunen <[email protected]>
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).


this seems like a copy-pasting: the year, the company name and the contributor are incorrect. as you are changing this, please adopt the reuse syntax:

Suggested change

# Copyright 2020 Coop IT Easy SCRL fs

# Robin Keunen <[email protected]>

# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

# SPDX-FileCopyrightText: 2024 Coop IT Easy SC

#

# SPDX-License-Identifier: AGPL-3.0-or-later

huguesdk · 2024-12-17T09:14:24Z

foodhub_picking/__manifest__.py

@@ -0,0 +1,14 @@
+{


missing copyright:

Suggested change

{

# SPDX-FileCopyrightText: 2024 Coop IT Easy SC

#

# SPDX-License-Identifier: AGPL-3.0-or-later

{

huguesdk · 2024-12-17T09:14:53Z

foodhub_picking/__init__.py

@@ -0,0 +1 @@
+from . import models


missing copyright:

Suggested change

from . import models

# SPDX-FileCopyrightText: 2024 Coop IT Easy SC

#

# SPDX-License-Identifier: AGPL-3.0-or-later

from . import models

huguesdk · 2024-12-17T09:15:17Z

foodhub_picking/models/__init__.py

@@ -0,0 +1 @@
+from . import stock_move_line


missing copyright:

Suggested change

from . import stock_move_line

# SPDX-FileCopyrightText: 2024 Coop IT Easy SC

#

# SPDX-License-Identifier: AGPL-3.0-or-later

from . import stock_move_line

huguesdk · 2024-12-17T09:16:41Z

foodhub_picking/reports/report_picking.xml

+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>


missing copyright:

Suggested change

<?xml version="1.0" encoding="utf-8" ?>

<odoo>

<?xml version="1.0" encoding="utf-8" ?>



<odoo>

huguesdk · 2024-12-17T09:34:28Z

foodhub_picking/reports/report_picking.xml

+        <xpath expr="//div[@name='div_origin']/strong[2]" position="attributes">
+             <attribute name="class">invisible</attribute>
+        </xpath>


Suggested change

<xpath expr="//div[@name='div_origin']/strong[2]" position="attributes">

<attribute name="class">invisible</attribute>

</xpath>

<xpath expr="//div[@name='div_origin']/strong[2]" position="attributes">

<attribute name="invisible">1</attribute>

</xpath>

victor-champonnois requested a review from huguesdk December 12, 2024 10:46

github-grap-bot added the needs review label Dec 12, 2024

[ADD] foodhub_picking_operations

8e5d42c

victor-champonnois force-pushed the 16.0-foodhub_picking_order branch from 1d111be to 8e5d42c Compare December 12, 2024 10:51

[IMP] switch SO name and picking name

5c2c349

huguesdk requested changes Dec 13, 2024

View reviewed changes

victor-champonnois and others added 4 commits December 16, 2024 10:05

Update foodhub_picking_operations/reports/report_picking_operations.xml

7b58729

Co-authored-by: hugues de keyzer <[email protected]>

Update foodhub_picking_operations/reports/report_picking_operations.xml

33f3856

Co-authored-by: hugues de keyzer <[email protected]>

fixup

61f6913

fixup

cc50ea3

huguesdk requested changes Dec 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [ADD] foodhub_picking_operations #122

[16.0] [ADD] foodhub_picking_operations #122

victor-champonnois commented Dec 12, 2024 •

edited

Loading

huguesdk Dec 13, 2024

victor-champonnois Dec 16, 2024 •

edited

Loading

victor-champonnois Dec 16, 2024

huguesdk Dec 17, 2024

huguesdk Dec 13, 2024

victor-champonnois Dec 16, 2024

huguesdk Dec 13, 2024

victor-champonnois Dec 16, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

huguesdk Dec 17, 2024

		_order = "product_category,product_default_code"

		product_category = fields.Many2one(related="product_id.categ_id", store=True)

		from odoo import fields, models


		class StockMove(models.Model):

	class StockMove(models.Model):
	class StockMoveLine(models.Model):

-{
+# SPDX-FileCopyrightText: 2024 Coop IT Easy SC
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+{

[16.0] [ADD] foodhub_picking_operations #122

Are you sure you want to change the base?

[16.0] [ADD] foodhub_picking_operations #122

Conversation

victor-champonnois commented Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

victor-champonnois Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-champonnois commented Dec 12, 2024 •

edited

Loading

victor-champonnois Dec 16, 2024 •

edited

Loading