Vine: Refactor Task Kill #4019
Merged
Vine: Refactor Task Kill #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess/failure paths for tasks will delete the task sandbox. Fixes a storage leak that resulted from task sandboxes not always being cleaned up.
btovar
approved these changes
Jan 13, 2025
|
ready to merge? |
|
RTM |
btovar
pushed a commit
that referenced
this pull request
Jan 13, 2025
…ess/failure paths for tasks will delete the task sandbox. (#4019) Fixes a storage leak that resulted from task sandboxes not always being cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Task sandboxes were not getting cleaned up under various failure conditions, resulting in a storage leak.
This ensures that "kill" gets sent for every call to reap_task_from_worker.
Also clarified comments to make clear what's going on.
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.