Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: send protocol version in manager_lean_to_jx #3970

Merged

Conversation

JinZhou5042
Copy link
Member

@JinZhou5042 JinZhou5042 commented Nov 5, 2024

Proposed Changes

This PR eliminates this warning message:
QQ_1730826432091

Merge Checklist

The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Update the manual to reflect user-visible changes.
  • Type Labels Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

@JinZhou5042 JinZhou5042 requested a review from dthain November 5, 2024 17:28
@JinZhou5042 JinZhou5042 added bug For modifications that fix a flaw in the code. TaskVine labels Nov 5, 2024
@JinZhou5042 JinZhou5042 self-assigned this Nov 5, 2024
@dthain dthain merged commit df0d4f2 into cooperative-computing-lab:master Nov 5, 2024
10 checks passed
@JinZhou5042 JinZhou5042 deleted the factory_version_fix branch November 18, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For modifications that fix a flaw in the code. TaskVine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants