Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
While calling DaskVine get API, we have two arguments for the same purpose,
worker_transfers
andlazy_transfers
, the later one is marked as deprecated.The default value for both is
True
. If the users want to activate it, they may passThis works well. However, if they want to deactivate it, they may pass
Only the last works, because
worker_transfers or lazy_transfers
is always True if only one argument is explicitly passed by the users.This PR changes the logic to - if one of the two arguments is False, then
self.worker_transfers
is False, otherwise True.Merge Checklist
The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.
make test
Run local tests prior to pushing.make format
Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lint
Run lint on source code prior to pushing.