Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix Build Namespace and Broken Links #3925

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

dthain
Copy link
Member

@dthain dthain commented Aug 29, 2024

Proposed Changes

The online version of the docs had big blank spaces where the example code should be!

  • I fixed the instructions (and use of paths) in the examples so that our testing procedure now matches the deployment procedure.
  • The settings for pymdown_extensions now fail if a file cannot be included, so we will actually see such problems in the future.
  • A number of broken internal links and references are now fixed.

Merge Checklist

The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Update the manual to reflect user-visible changes.
  • Type Labels Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

dthain added 3 commits August 29, 2024 13:59
…s it.

- Update pymdown snippets to allow inclusion outside of manual root.
- Update pymdown snippets to fail on build if snippet can't be found.
@dthain dthain added bug For modifications that fix a flaw in the code. documentation labels Aug 29, 2024
@dthain dthain merged commit 034aba1 into cooperative-computing-lab:master Aug 29, 2024
8 checks passed
colinthomas-z80 pushed a commit to colinthomas-z80/cctools that referenced this pull request Oct 15, 2024
…3925)

* - Modify doc build and test instructions to match how readthedocs does it.
- Update pymdown snippets to allow inclusion outside of manual root.
- Update pymdown snippets to fail on build if snippet can't be found.

* Remove symlink to code-examples, make examples refer to examples in source dir directly.

* Fix up broken internal references.
btovar pushed a commit that referenced this pull request Oct 21, 2024
* - Modify doc build and test instructions to match how readthedocs does it.
- Update pymdown snippets to allow inclusion outside of manual root.
- Update pymdown snippets to fail on build if snippet can't be found.

* Remove symlink to code-examples, make examples refer to examples in source dir directly.

* Fix up broken internal references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For modifications that fix a flaw in the code. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant