-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DaskVine Serverless #3581
DaskVine Serverless #3581
Conversation
…nto daskvine_serverless
…nto daskvine_serverless
Taking a quick look, I see that an output file is declared in |
No, there is no |
I'm asking you if it needs one. :) |
It can be added to the destructor however, the DaskVine executor will need only to delete the FunctionCall tasks and remove the files once all the tasks that may consume its output are completed. |
@BarrySlyDelgado please rebase or merge on master to pick up the memory leak fix from @JinZhou5042 . |
@BarrySlyDelgado is this the code being used to run HEP applications? If so, rebase on master and let's get this merged. |
Hello? |
Yes, this is currently used for testing function calls for the HEP applications. |
taskvine/src/bindings/python3/ndcctools/taskvine/dask_executor.py
Outdated
Show resolved
Hide resolved
I'm ready to merge this once you have pulled in the necessary changes from master. |
Proposed changes
This enables serverless with DaskVine. A new class, FunctionCallDask, creates function calls instead of PythonTasks. These options set with the
task_mode
option.Post-change actions
Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.
make test
Run local tests prior to pushing.make format
Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lint
Run lint on source code prior to pushing.Additional comments
I have tested it on a small scale locally and distributed. There are still some things to fix.