-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker support + Upgrade to Ruby 3 and Rails 7 💫 #722
Conversation
…e webdrivers anymore)
@microstudi I pushed some small tweaks (basically this commit: e90d8e2), but it seems it broke the Docker build job 😅 That's because I made |
Conceptually, are you sure to use If you really want to put amazon as a default, just add this env var in both services (
|
I just made e90d8e2#diff-da60b4e96eff2b132991226d308949e23f4ef3aad45ad59edd09cbc32cc6251eL49 In local and test, it makes sense to use local storage, but for staging, pro or any production-like env, it seems a better default I'd say. Moving local files between different servers would be a pain, but pushing them to S3 make it more flexible. |
I see, it's ok. But because the docker compose is for testing the production docker it picks up this value. Just adding the ENV var will solve this then. Go ahead! |
WHAT