Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support + Upgrade to Ruby 3 and Rails 7 💫 #722

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

markets
Copy link
Collaborator

@markets markets commented Dec 9, 2023

WHAT

  • Docker
  • Ruby 3
  • Rails 7
  • Puma

@markets markets changed the title Upgrade to Ruby 3 💫 Upgrade to Ruby 3 and Rails 7 💫 Dec 9, 2023
@markets markets marked this pull request as ready for review December 30, 2023 21:02
@markets markets added the infra label Jan 9, 2024
@markets markets changed the title Upgrade to Ruby 3 and Rails 7 💫 Add Docker support + Upgrade to Ruby 3 and Rails 7 💫 Feb 12, 2024
@markets
Copy link
Collaborator Author

markets commented Feb 12, 2024

@microstudi I pushed some small tweaks (basically this commit: e90d8e2), but it seems it broke the Docker build job 😅 That's because I made :amazon the default for pro right? Hmmm 🤔 let me know what you think, but it seems a sensible default for pro.

@microstudi
Copy link
Contributor

Conceptually, are you sure to use amazonby default in all environmonents? does not that makes it difficult for developing?
What is probably happening is that the test docker compose is precisely using local files to run the app.

If you really want to put amazon as a default, just add this env var in both services (app, sidekiq) in the docker-compose.yml file:

STORAGE_PROVIDER=local

@markets
Copy link
Collaborator Author

markets commented Feb 13, 2024

I just made :amazon the default in production:

e90d8e2#diff-da60b4e96eff2b132991226d308949e23f4ef3aad45ad59edd09cbc32cc6251eL49

In local and test, it makes sense to use local storage, but for staging, pro or any production-like env, it seems a better default I'd say. Moving local files between different servers would be a pain, but pushing them to S3 make it more flexible.

@microstudi
Copy link
Contributor

I just made :amazon the default in production:

e90d8e2#diff-da60b4e96eff2b132991226d308949e23f4ef3aad45ad59edd09cbc32cc6251eL49

In local and test, it makes sense to use local storage, but for staging, pro or any production-like env, it seems a better default I'd say. Moving local files between different servers would be a pain, but pushing them to S3 make it more flexible.

I see, it's ok. But because the docker compose is for testing the production docker it picks up this value. Just adding the ENV var will solve this then. Go ahead!

@markets markets merged commit 73cdb45 into develop Feb 13, 2024
6 checks passed
@markets markets deleted the ruby_3 branch February 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants