adds petition button on organizations/show page, plus bug fix and security fix

[nflorentin]

Security fix:
do not let client side send the petition status, controller should define it

Improvements:
New petition button and destroy member buttons are extracted into a partial and use in organizations/show page.

Bug fix:
An admin on an organization A was seeing "edit organization button" on organizations/show page of organization B.

Closes #715

[markets]

Thanks again @nflorentin!

We're going to test a bit in staging (https://staging.timeoverflow.org) and prepare a release!

Current diff: v4.3.0...develop

[markets]

Deployed to staging @sseerrggii @nflorentin 🎉

These are all the changes: v4.3.0...develop

If you can take a look 👁️ and validate it ✔️, I can prepare the production release tomorrow or during the weekend.

Thank you so much!

By the way @nflorentin, in staging you can use the users defined in our seeds: https://github.com/coopdevs/timeoverflow/blob/develop/db/seeds.rb#L4 to test the app.

[sseerrggii]

I crash staging testing 🤕

I changed de document (terms and conditions) to validate #712 and when I tried to enter with a new user i saw too_many_redirects error

Also I tried to test #714 uploading SVG file on organization form https://staging.timeoverflow.org/organizations/7/edit and returns error 500. I can not undo it, i tried to restart application but still some pages return error

[nflorentin]

@sseerrggii I will try to reproduce the 2 problems tomorrow.

Can you send me the svg you uploaded ?

Thanks

[sseerrggii]

Yes, it was a random svg, but exactly was

[nflorentin]

@sseerrggii I reproduced the problem with organization logo and fix it, I made a new PR.

But I could not reproduce the problem with terms document. What I did was :

• with super admin, make a little change to terms document, and save
• in private chrome tab, sign in as member
  As member, I'm seeing the new term document to accept. I do not see the infinite redirects loop, don't know why.
  Did you do the exact same on staging ?

I tried to connect to staging and I'm effectively have the infinite redirects loop.
I would need staging logs to understand the problem.

@markets for info

[markets]

Hi @nflorentin @sseerrggii 👋🏼

Just redeployed the SVG error on staging (5d56ea6), but I'm unable to reproduce the "too many redirects" issue neither.

[sseerrggii]

Hi!!

SVG probleme fixed ✔️

I can not reproduce again the problem with terms and conditions, let's approve it! I will ask @danypr92 to grant access to @nflorentin to staging server

Thank you @nflorentin and @markets 🥇

[markets]

Nice! Thanks @sseerrggii 🤝

I'm going to prepare a production release during this weekend 🎉

[markets]

@nflorentin @sseerrggii v4.4.0 is now live 🚀 https://github.com/coopdevs/timeoverflow/releases/tag/v4.4.0

[nflorentin]

Thanks @sseerrggii and @markets for your work

Have a nice week-end !