OrganizationNotifier: send email to confirmed users only

app/jobs/organization_notifier_job.rb

@@ -1,7 +1,7 @@
 # A weekly digest email.
 #
 # Strategy: go throught all organizations and take latest active posts from last week
-# posted by active members. Send an email to all active and online members
+# posted by active members. Send an email to all confirmed, active and online members
 # with the email notifications enabled with those posts. Group emails by user's locale.
 
 # Schedule defined in config/schedule.yml file.
@@ -24,11 +24,11 @@ def perform
   private
 
   def users_by_locale(organization)
-    with_notifications = organization.users.online_active.actives.notifications
-    org_locales = with_notifications.pluck(:locale).uniq
+    org_users = organization.users.online_active.actives.confirmed.notifications
+    org_locales = org_users.pluck(:locale).uniq
 
     org_locales.each_with_object({}) do |locale, hash|
-      hash[locale] = with_notifications.where(locale: locale)
+      hash[locale] = org_users.where(locale: locale)
     end
   end
 end

app/mailers/organization_notifier.rb

@@ -2,7 +2,6 @@ class OrganizationNotifier < ActionMailer::Base
   default from: "\"TimeOverflow\" <[email protected]>"
 
   def recent_posts(posts, locale, users)
-    # last 10 posts of offers and inquiries
     @offers = posts.where(type: "Offer").take(10)
     @inquiries = posts.where(type: "Inquiry").take(10)
 

app/models/user.rb

@@ -41,6 +41,7 @@ class User < ApplicationRecord
   scope :actives, -> { joins(:members).where(members: { active: true }) }
   scope :online_active, -> { where("sign_in_count > 0") }
   scope :notifications, -> { where(notifications: true) }
+  scope :confirmed, -> { where.not(confirmed_at: nil) }
 
   validates :username, presence: true
   validates :email, presence: true, uniqueness: true

spec/mailers/organization_notifier_spec.rb

@@ -2,7 +2,7 @@
   let(:test_organization) { Fabricate(:organization) }
   let!(:offer) { Fabricate(:offer, organization: test_organization) }
   let!(:inquiry) { Fabricate(:inquiry, organization: test_organization) }
-  let(:user) { Fabricate(:user, email: "user@example.com", locale: :en) }
+  let(:user) { Fabricate(:user, email: "user@timeoverflow.org", locale: :en) }
   let(:member) { Fabricate(:member, organization: test_organization, user: user) }
 
   describe "send an email" do
@@ -17,7 +17,7 @@
     let(:mail) { OrganizationNotifier.recent_posts(test_organization.posts, :en, [user]) }
 
     it "receive email only active and online users" do
-      expect(mail.bcc).to eql(["user@example.com"])
+      expect(mail.bcc).to eql(["user@timeoverflow.org"])
     end
     it "to should be null" do
       expect(mail.to).to be_nil