Skip to content

Commit

Permalink
fix: using externals results in endless loop
Browse files Browse the repository at this point in the history
related to the changes with target dir in recent release; calls to
external packages now use -d option
  • Loading branch information
ThorstenSuckow committed Dec 15, 2022
1 parent fd42b70 commit 0d8747d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ so existing comments will get lost on the way.
Show the **help** screen.
## Configuration
#### `.deloreanrc.json`
### `.deloreanrc.json`
The configuration file required by **delorean**.
Contains options for setting JSON-keys available with Sencha's Ext JS `package.json` / `app.json` that should be used
for determining the JavaScript-source files for transpiling.
Expand All @@ -149,10 +149,10 @@ for determining the JavaScript-source files for transpiling.
"builds": [
"desktop", "shared"
],
"externals": [
"./node_modules/@lib/externalpackage",
"./packages/local/math"
]
"externals": [
"./node_modules/@lib/externalpackage",
"./packages/local/math"
]
}
```

Expand Down
4 changes: 2 additions & 2 deletions bin/bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,11 @@ const processExternals = (revert) => {
if (revert === true) {
log(chalk.green(`${cfgExternal} has .deloreanrc.json, reverting...`));
log(chalk.yellow(quote()));
cmd = `npx --prefix ${cfgExternal} delorean -r`;
cmd = `npx --prefix ${cfgExternal} delorean -r -d ${cfgExternal}`;
} else {
log(chalk.green(`${cfgExternal} has .deloreanrc.json, preparing...`));
log(chalk.yellow(quote()));
cmd = `npx --prefix ${cfgExternal} delorean -p`;
cmd = `npx --prefix ${cfgExternal} delorean -p -d ${cfgExternal}`;
}


Expand Down

0 comments on commit 0d8747d

Please sign in to comment.