Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an accessibility audit on my project. Part of the issues concern Converse.
Here are the required fixes. I have separated them in different commits, so we can discuss if necessary.
Here is the list of changes:
accessibility with screen readers.
focusable element, and tab should give the focus to next focusable
element if the input is empty.
chatbox titles, to improve navigation with screen readers.
ignores the image
As my project only uses Converse in singleton mode to display one MUC, the audit is incomplete.
I tried to fix some of the issues more widely than what was required for my project, but i can have missed some points.
CHANGES.md
document it in
docs/source/configuration.rst
with
make check
or you can run them in the browser by runningmake serve
and then opening
http://localhost:8000/tests.html
.