Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message dropdown menu placement #3474

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix message dropdown menu placement #3474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/shared/chat/message-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,8 @@ class MessageActions extends CustomElement {
const buttons = await this.getActionButtons();
const items = buttons.map(b => MessageActions.getActionsDropdownItem(b));
if (items.length) {
// We want to let the message actions menu drop upwards if we're at the
// bottom of the message history, and down otherwise. This is to avoid
// the menu disappearing behind the bottom panel (toolbar, textarea etc).
// That's difficult to know from state, so we're making an approximation here.
const should_drop_up = this.model.collection.length > 3 && this.model === this.model.collection.last();
return html`<converse-dropdown
class="chat-msg__actions btn-group ${should_drop_up ? 'dropup dropup--left' : 'dropstart'}"
class="chat-msg__actions btn-group dropstart"
.items=${items}
></converse-dropdown>`;
} else {
Expand Down
Loading