Fix singleton/fullscript mode with bootstrap5: #3472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that negative margin is no more needed with the recent changes.
There was a regression in fullscreen mode. Converse was vertically shifted.
JohnXLivingston
changed the title
|
LGTM (without testing it). BTW, I'm planning to get rid of the That's at least the idea right now. |
Seems a good idea. |
* fix left positioning.
|
I just made another commit. I copied the |
|
Merged it manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that negative margin is no more needed with the recent changes.
And there was a regression on fullscreen mode, the chat was not positioned correctly.
PS: for commit 28f72a6 , i don't know if it should also impact
converse-mobilemode.