Refactoring #3241
Closed
Refactoring #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
force-pushed
the
jcbrand/strophe-ts
branch
from
d634270
to
0db1ce1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcbrand
force-pushed
the
jcbrand/strophe-ts
branch
2 times, most recently
from
6c0f760
to
5a14bf5
Compare
jcbrand
force-pushed
the
jcbrand/strophe-ts
branch
5 times, most recently
from
c31f237
to
2bdea15
Compare
Previously the `overrides` functionality of `pluggable.js` was used to `override` the `model` function on the `ChatBoxes` collection, so that different types of chatboxes could be created (e.g. MUC, ChatBox, Feed). This has been replaced with a registry, `api.chatboxes.registry`. Use `api.chatboxes.registry.add(type, model)` to add a new type of chatbox to the collection. Then when `api.chatboxes.create(attrs, options)` is called, the right type of chatbox will be created if `attrs.type` is the `type` in the registry.
jcbrand
force-pushed
the
jcbrand/strophe-ts
branch
from
2bdea15
to
1cbb5cc
Compare
Use the builtin History API and event listeners.
| import chat_api from './api.js'; | ||
| import { Collection } from '@converse/skeletor/src/collection'; | ||
| import { _converse, api, converse } from '../../index.js'; | ||
| import { _converse, api, converse, u } from '../../index.js'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| import ChatRoomOccupant from './occupant.js'; | ||
| import ChatRoomOccupants from './occupants.js'; | ||
| import affiliations_api from './affiliations/api.js'; | ||
| import muc_api from './api.js'; | ||
| import { Collection } from '@converse/skeletor/src/collection'; | ||
| import { _converse, api, converse } from '../../index.js'; | ||
| import { _converse, api, converse, u } from '../../index.js'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| @@ -35,7 +35,7 @@ | |||
| return; | |||
| } | |||
| if (api.settings.get('allow_url_history_change')) { | |||
| _converse.router.history.navigate(`#${oldest_message.get('msgid')}`); | |||
| history.pushState(null, '', `#${oldest_message.get('msgid')}`) | |||
Check notice
Code scanning / CodeQL
Semicolon insertion Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.