Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose support #27

Closed
wants to merge 2 commits into from
Closed

docker-compose support #27

wants to merge 2 commits into from

Conversation

lerra
Copy link

@lerra lerra commented Apr 17, 2019

Created the PR for the issue #13 that I created

@converge
Copy link
Owner

that's amazing @lerra, thank you so much! this will help a lot of people!

I'll review and merge it this weekend.

@lerra
Copy link
Author

lerra commented Apr 25, 2019

@converge any update? :-)

@converge
Copy link
Owner

I had a look this weekend, but there is some issues like
[1] Error: Please install sqlite3 package manually
and it's creating empty folder inside the root folder, I also changed /root folder to /opt in the config files, I'll have time again this weekend, and I'll propose the changes, and ask for your thoughts.

@converge
Copy link
Owner

just created a new Docker image, could you test it ? #36

@converge converge closed this May 17, 2019
@lerra
Copy link
Author

lerra commented May 19, 2019

It works for me as long as I hardcode - ${INSTAPY_FOLDER}:${INSTAPY_FOLDER} from the docker compose file to the folders where instapy is, but I guess that was the intent of it and not to have it dynamic ?

@converge
Copy link
Owner

Hey, I made a PR last week with a working image and Docker container, did you have some issue using my setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants