Remove dependency on Nette\Http\Request #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there was a problem when you try to use this exntesion with php runtimes like swoole/roadrunner/falconphp, because you can't have Nette Request object, but you need your own implementation of IRequest that will switch its variables and state between requests.
The problem wasn't only Header resolver itself, because if you are not using it, extension will try to create it in DI and it fails in constructor, so extension could not work at all, so I moved one method for resolving locale from Nette Request to Header resolver.