Remove compilation of LibN.java #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
force-pushed
the
remove-javac-dependency
branch
from
15230b6 to
9d38cd5
Compare
Add added/removed methods to the MoteType interface, and call that from the simulation when the motetype is added/removed. Inside ContikiMoteType, replace the current class-loader-tweaking with an arena that is closed when the motetype is removed from the simulation. This will close the shared library as well. This reduces the runtime for 07-simulation-base from 1m 8s to 50s.
After switching ContikiMoteType to use an Arena, this is no longer required.
This class no longer needs to be exposed to the world.
pjonsson
force-pushed
the
remove-javac-dependency
branch
from
fc8b362 to
319145c
Compare
nfi
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an Arena from the FFI preview in Java 20 to track scopes of shared libraries.
This speeds up 07-simulation-base from 1m 8s to 50s.