Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEC-3232]Add template and remove old deployment stuff #23

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Conversation

roryscarson
Copy link
Collaborator

No description provided.

@roryscarson roryscarson marked this pull request as ready for review September 26, 2023 12:41
@roryscarson roryscarson requested a review from a team as a code owner September 26, 2023 12:41
@roryscarson
Copy link
Collaborator Author

There was an error verifying catalog-info-template.yaml:
Error: "metadata.name" is not valid; expected a string that is sequences of [a-zA-Z0-9] separated by any of [-_.], at most 63 characters in total but found "${{ github.event.repository.name }}". To learn more about catalog file format, visit: https://github.com/backstage/backstage/blob/master/docs/architecture-decisions/adr002-default-catalog-file-format.md

ugggghhhh

@roryscarson
Copy link
Collaborator Author

@karankohli-cf this is probably good for now. Depending on how the code to create the PR will handle creating the file we might need to change the template from envvars to something else, but all the info we want to track is here.

@roryscarson roryscarson merged commit 4bb3ab0 into main Sep 28, 2023
7 of 8 checks passed
@karankohli-cf karankohli-cf deleted the sec-3232 branch October 9, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants