Fix phpcq 2 issues #591
Merged
Fix phpcq 2 issues #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove a unused "c" at the end of the file.
discordier
force-pushed
the
feature/phpcq-for-2.3.0
branch
from
77f7828
to
a7cde95
Compare
discordier
changed the title
This is the most relaxed level but we have a shitload of warnings in the current code base. Let's move incremental.
Parameter was not adjusted in 4b614e6.
The values are always null unless setter is called first.
baumannsven
force-pushed
the
release/2.3.0
branch
from
154afd9
to
dbe2288
Compare
zonky2
force-pushed
the
feature/phpcq-for-2.3.0
branch
5 times, most recently
from
5c75a1d
to
b1bbcbf
Compare
zonky2
force-pushed
the
feature/phpcq-for-2.3.0
branch
8 times, most recently
from
04bfa05
to
a0a4196
Compare
zonky2
force-pushed
the
feature/phpcq-for-2.3.0
branch
4 times, most recently
from
e535b41
to
b8cf074
Compare
zonky2
force-pushed
the
feature/phpcq-for-2.3.0
branch
from
b8cf074
to
313d1f7
Compare
…ature/phpcq-for-2.3.0 # Conflicts: # src/Contao/View/Contao2BackendView/ActionHandler/AbstractListShowAllHandler.php # src/Contao/View/Contao2BackendView/ActionHandler/ShowHandler.php
…ature/phpcq-for-2.3.0
…ature/phpcq-for-2.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues found by phpcq 2 on release 2.3.