Add kube play support for CDI resource allocation #25010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now handle CDI qualified names being passed to resources.limits. The support for that was already in libpod as of ab7f609 when passed via the devices list. this just hooks the kube yaml parser up to it. Additionally we introduce `podman.io/device` that accepts device paths as names and is transparently translated to mimick --device. This allows bringing arbitrary devices into the container via similar, although incompatible with, k8s mechanics: ```yaml resources: requests: podman.io/device=/dev/kmsg: 1 ``` Fixes: containers#17833 Signed-off-by: Robert Günzler <[email protected]>
|
/approve |
openshift-ci
bot
added
the
approved
|
Thanks @robertgzr |
bachp
approved these changes
Jan 14, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bachp, giuseppe, robertgzr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ec6b035
into
containers:main
79 of 80 checks passed
|
@rhatdan @giuseppe where should this be documented? i guess i would look for it somewhere here: https://docs.podman.io/en/latest/markdown/podman-kube-play.1.html |
|
Yes document it in the man page in docs/source/markdown/podman-kube-play.1.md.in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now handle CDI qualified names being passed to resources.limits. The
support for that was already in libpod as of ab7f609
when passed via the devices list. this just hooks the kube yaml parser
up to it.
Additionally we introduce
podman.io/devicethat accepts device pathsas names and is transparently translated to mimick --device. This allows
bringing arbitrary devices into the container via similar, although
incompatible with, k8s mechanics:
Fixes: #17833
Signed-off-by: Robert Günzler [email protected]